Skip to content

fix: DataFusion benchmark panicked: failed to cast '2013-07-01' to UInt16#21498

Merged
alamb merged 1 commit intoapache:mainfrom
xiedeyantu:benchmark
Apr 10, 2026
Merged

fix: DataFusion benchmark panicked: failed to cast '2013-07-01' to UInt16#21498
alamb merged 1 commit intoapache:mainfrom
xiedeyantu:benchmark

Conversation

@xiedeyantu
Copy link
Copy Markdown
Member

@xiedeyantu xiedeyantu commented Apr 9, 2026 •
edited
Loading

Which issue does this PR close?

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the core Core DataFusion crate label Apr 9, 2026
@xiedeyantu
Copy link
Copy Markdown
Member Author

xiedeyantu commented Apr 9, 2026

A problem was exposed during the benchmark tests in #21236, as follows:

thread 'main' (37232) panicked at datafusion/core/benches/sql_planner.rs:57:14:
called `Result::unwrap()` on an `Err` value: Context("Optimizer rule 'simplify_expressions' failed", ArrowError(CastError("Cannot cast string '2013-07-01' to value of UInt16 type"), Some("")))
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
error: bench failed, to rerun pass `-p datafusion --bench sql_planner`

I've attempted to make an adjustment, though I'm not entirely sure if it's correct. If you have a moment, could you please take a look? Thanks! @xudong963 @neilconway
I referred to this source, but I'm not sure if this approach is correct, or perhaps there is an issue with my PR; I currently don't know how to pinpoint the problem. link

@xiedeyantu xiedeyantu mentioned this pull request Apr 9, 2026
Open
@xiedeyantu
Copy link
Copy Markdown
Member Author

xiedeyantu commented Apr 10, 2026

@alamb I'm not sure if the main branch has this issue; could you help run the benchmarks on this PR?

@alamb
Copy link
Copy Markdown
Contributor

alamb commented Apr 10, 2026

Thank you @xiedeyantu

We can test this locally by running

cargo bench --profile=dev --bench sql_planner -- physical_plan_clickbench_q37

Which locally for me fails like this:

Benchmarking physical_plan_clickbench_q37: Warming up for 3.0000 s
thread 'main' (31249714) panicked at datafusion/core/benches/sql_planner.rs:57:14:
called `Result::unwrap()` on an `Err` value: Context("Optimizer rule 'simplify_expressions' failed", ArrowError(CastError("Cannot cast string '2013-07-01' to value of UInt16 type"), Some("")))
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

error: bench failed, to rerun pass `-p datafusion --bench sql_planner`

@alamb
Copy link
Copy Markdown
Contributor

alamb commented Apr 10, 2026

run benchmark sql_planner

@alamb
Copy link
Copy Markdown
Contributor

alamb commented Apr 10, 2026

I also verified the queyr passes locally for me

alamb
alamb approved these changes Apr 10, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @xiedeyantu 🙏

@xiedeyantu
Copy link
Copy Markdown
Member Author

xiedeyantu commented Apr 10, 2026

I also verified the queyr passes locally for me

Thank you for performing the local verification.

@adriangbot
Copy link
Copy Markdown

adriangbot commented Apr 10, 2026

🤖 Criterion benchmark running (GKE) | trigger
Instance: c4a-highmem-16 (12 vCPU / 65 GiB) | Linux bench-c4225379571-1056-8bq4q 6.12.55+ #1 SMP Sun Feb 1 08:59:41 UTC 2026 aarch64 GNU/Linux

CPU Details (lscpu) 
Architecture:                            aarch64
CPU op-mode(s):                          64-bit
Byte Order:                              Little Endian
CPU(s):                                  16
On-line CPU(s) list:                     0-15
Vendor ID:                               ARM
Model name:                              Neoverse-V2
Model:                                   1
Thread(s) per core:                      1
Core(s) per cluster:                     16
Socket(s):                               -
Cluster(s):                              1
Stepping:                                r0p1
BogoMIPS:                                2000.00
Flags:                                   fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache:                               1 MiB (16 instances)
L1i cache:                               1 MiB (16 instances)
L2 cache:                                32 MiB (16 instances)
L3 cache:                                80 MiB (1 instance)
NUMA node(s):                            1
NUMA node0 CPU(s):                       0-15
Vulnerability Gather data sampling:      Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit:             Not affected
Vulnerability L1tf:                      Not affected
Vulnerability Mds:                       Not affected
Vulnerability Meltdown:                  Not affected
Vulnerability Mmio stale data:           Not affected
Vulnerability Reg file data sampling:    Not affected
Vulnerability Retbleed:                  Not affected
Vulnerability Spec rstack overflow:      Not affected
Vulnerability Spec store bypass:         Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1:                Mitigation; __user pointer sanitization
Vulnerability Spectre v2:                Mitigation; CSV2, BHB
Vulnerability Srbds:                     Not affected
Vulnerability Tsa:                       Not affected
Vulnerability Tsx async abort:           Not affected
Vulnerability Vmscape:                   Not affected

Comparing benchmark (62eb3b8) to e1ad871 (merge-base) diff
BENCH_NAME=sql_planner
BENCH_COMMAND=cargo bench --features=parquet --bench sql_planner
BENCH_FILTER=
Results will be posted here when complete

File an issue against this benchmark runner

@adriangbot
Copy link
Copy Markdown

adriangbot commented Apr 10, 2026

Benchmark for this request failed.

Last 20 lines of output:

Click to expand 
Benchmarking physical_plan_clickbench_q34: Analyzing
Benchmarking physical_plan_clickbench_q35
Benchmarking physical_plan_clickbench_q35: Warming up for 3.0000 s

Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 7.3s, enable flat sampling, or reduce sample count to 50.
Benchmarking physical_plan_clickbench_q35: Collecting 100 samples in estimated 7.2758 s (5050 iterations)
Benchmarking physical_plan_clickbench_q35: Analyzing
Benchmarking physical_plan_clickbench_q36
Benchmarking physical_plan_clickbench_q36: Warming up for 3.0000 s

Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 9.2s, enable flat sampling, or reduce sample count to 50.
Benchmarking physical_plan_clickbench_q36: Collecting 100 samples in estimated 9.1814 s (5050 iterations)
Benchmarking physical_plan_clickbench_q36: Analyzing
Benchmarking physical_plan_clickbench_q37
Benchmarking physical_plan_clickbench_q37: Warming up for 3.0000 s

thread 'main' (37751) panicked at datafusion/core/benches/sql_planner.rs:57:14:
called `Result::unwrap()` on an `Err` value: Context("Optimizer rule 'simplify_expressions' failed", ArrowError(CastError("Cannot cast string '2013-07-01' to value of UInt16 type"), Some("")))
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
error: bench failed, to rerun pass `-p datafusion --bench sql_planner`

File an issue against this benchmark runner

@alamb
Copy link
Copy Markdown
Contributor

alamb commented Apr 10, 2026

(I think the remote benchmark fails when run on main -- so I will merge this one in)

@alamb alamb added this pull request to the merge queue Apr 10, 2026
Merged via the queue into apache:main with commit 5e60df6 Apr 10, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alamb alamb alamb approved these changes

Assignees

No one assigned

Labels

core Core DataFusion crate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DataFusion benchmark panicked: failed to cast '2013-07-01' to UInt16

3 participants

@xiedeyantu @alamb @adriangbot